Re: [PATCH net-next v1 1/1] net/sched: cbs: Use units.h instead of the copy of a definition

From: Simon Horman
Date: Thu Nov 30 2023 - 16:03:47 EST


On Tue, Nov 28, 2023 at 07:48:13PM +0200, Andy Shevchenko wrote:
> BYTES_PER_KBIT is defined in units.h, use that definition.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks, this looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

Did you consider a patch to update sja1105_main.c?
It also seems to have a copy of BYTES_PER_KBIT.