Re: [PATCH] samples: Replace strlcpy() with strscpy()

From: Kees Cook
Date: Thu Nov 30 2023 - 15:43:48 EST


On Thu, 16 Nov 2023 11:15:10 -0800, Kees Cook wrote:
> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead
> to linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove strlcpy()
> completely[2], replace strlcpy() here with strscpy().
>
> [...]

Applied to for-next/hardening, thanks!

[1/1] samples: Replace strlcpy() with strscpy()
https://git.kernel.org/kees/c/40b2519d7566

Take care,

--
Kees Cook