Re: [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count

[Sibi Sankar]

On 11/30/23 18:30, Cristian Marussi wrote:
> On Wed, Nov 29, 2023 at 12:27:48PM +0530, Sibi Sankar wrote:
> > The number of opps on certain variants of the X1E80100 SoC are greater
> > than current maximum, so increase the MAX_OPP count to the next log level
> > to accommodate that.
>
> Hi,

Hey Cristian,
Thanks for taking time to review the series.

> > Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> > ---
> >   drivers/firmware/arm_scmi/perf.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> > index 3344ce3a2026..edf34a3c4d6a 100644
> > --- a/drivers/firmware/arm_scmi/perf.c
> > +++ b/drivers/firmware/arm_scmi/perf.c
> > @@ -24,7 +24,7 @@
> >   #include "protocols.h"
> >   #include "notify.h"
> >   
> > -#define MAX_OPPS		16
> > +#define MAX_OPPS		24
>
> There is an hashtable, opps_by_freq, sized by an ilog2()....
>
> ....so, can we stick to a power-of-2 like 32 instead ?
> (and be more future proof too...)

Thanks, will get this changed in the next re-spin.

> Other than this, LGTM
>
> Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>
>
> Thanks,
> Cristian