Re: linux-next: Tree for Nov 30 (mm/zswap.c)

From: Nhat Pham
Date: Thu Nov 30 2023 - 13:52:11 EST


On Thu, Nov 30, 2023 at 9:16 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
>
>
> On 11/29/23 19:03, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231129:
> >
>
> on i386, loongarch, ppc64, riscv32:
> when CONFIG_MEMCG is not set.
>
>
> ../mm/zswap.c: In function 'mem_cgroup_from_entry':
> ../mm/zswap.c:313:31: error: implicit declaration of function 'obj_cgroup_memcg'; did you mean 'obj_cgroup_put'? [-Werror=implicit-function-declaration]
> 313 | return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
> | ^~~~~~~~~~~~~~~~
> | obj_cgroup_put
> ../mm/zswap.c:313:62: warning: pointer/integer type mismatch in conditional expression
> 313 | return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
> | ^
> ../mm/zswap.c: In function 'shrink_worker':
> ../mm/zswap.c:984:31: error: invalid use of undefined type 'struct mem_cgroup'
> 984 | css_get(&memcg->css);
> | ^~
>
>
>
> --
> ~Randy
>

Thanks for the report, Randy! I'm fixing this for the !CONFIG_MEMCG
case. A new version of this patch series should be sent out in a short
while.