Re: [PATCH v2 01/10] gpiolib: provide gpiochip_dup_line_label()

From: Andy Shevchenko
Date: Thu Nov 30 2023 - 11:27:26 EST


On Thu, Nov 30, 2023 at 02:46:21PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> gpiochip_is_requested() not only has a misleading name but it returns
> a pointer to a string that is freed when the descriptor is released.
>
> Provide a new helper meant to replace it, which returns a copy of the
> label string instead.

...

> + * Must not be called from atomic context.

Put the respective lockdep annotation.

...

> + char *cpy;

So, why not naming it fully, i.e. "copy"?

--
With Best Regards,
Andy Shevchenko