Re: [PATCH 07/16] fs: add inode operations to get/set/remove fscaps

From: Seth Forshee (DigitalOcean)
Date: Thu Nov 30 2023 - 10:36:42 EST


On Thu, Nov 30, 2023 at 07:32:19AM +0200, Amir Goldstein wrote:
> On Wed, Nov 29, 2023 at 11:51 PM Seth Forshee (DigitalOcean)
> <sforshee@xxxxxxxxxx> wrote:
> >
> > Add inode operations for getting, setting and removing filesystem
> > capabilities rather than passing around raw xattr data. This provides
> > better type safety for ids contained within xattrs.
> >
> > Signed-off-by: Seth Forshee (DigitalOcean) <sforshee@xxxxxxxxxx>
> > ---
> > include/linux/fs.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index 98b7a7a8c42e..a0a77f67b999 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -2002,6 +2002,11 @@ struct inode_operations {
> > int);
> > int (*set_acl)(struct mnt_idmap *, struct dentry *,
> > struct posix_acl *, int);
> > + int (*get_fscaps)(struct mnt_idmap *, struct dentry *,
> > + struct vfs_caps *);
> > + int (*set_fscaps)(struct mnt_idmap *, struct dentry *,
> > + const struct vfs_caps *, int flags);
> > + int (*remove_fscaps)(struct mnt_idmap *, struct dentry *);
> > int (*fileattr_set)(struct mnt_idmap *idmap,
> > struct dentry *dentry, struct fileattr *fa);
> > int (*fileattr_get)(struct dentry *dentry, struct fileattr *fa);
> >
>
> Please document in Documentation/filesystems/{vfs,locking}.rst

Done for v2.