Re: [PATCH 1/7] rust: file: add Rust abstraction for `struct file`

From: Greg Kroah-Hartman
Date: Thu Nov 30 2023 - 09:59:32 EST


On Thu, Nov 30, 2023 at 02:53:35PM +0000, Benno Lossin wrote:
> On 11/29/23 13:51, Alice Ryhl wrote:
> > +/// Flags associated with a [`File`].
> > +pub mod flags {
> > + /// File is opened in append mode.
> > + pub const O_APPEND: u32 = bindings::O_APPEND;
>
> Why do all of these constants begin with `O_`?

Because that is how they are defined in the kernel in the C code. Why
would they not be the same here?

thanks,

greg k-h