Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible

[Michal Simek]

On 11/30/23 10:29, Krzysztof Kozlowski wrote:
> On 30/11/2023 10:19, Michal Simek wrote:
> > The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
> > compatible") make compatible string for child nodes mandatory that's why
> > add it.
> >
> > Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
> > ---
> >
> >   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > index f5e1eb8cb3b7..eaba466804bc 100644
> > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
> >   
> >   		ipi_mailbox_pmu1: mailbox@ff9905c0 {
> >   			bootph-all;
> > +			compatible = "xlnx,zynqmp-ipi-dest-mailbox";
>
> Probably you want it as first property. Although then reg is also placed
> odd, but it's all because bootph-all was put at the beginning.

When DTS conding style is approved I will need to resort all that nodes based on 
it. I did this change to be aligned with current style which this file has.
What do you think?

Thanks,
Michal