Re: [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property

From: Krzysztof Kozlowski
Date: Thu Nov 30 2023 - 03:55:57 EST


On 29/11/2023 15:38, Mao Jinlong wrote:
> The inport of funnel@3023000 connects to a source which is not supported
> in current linux kernel. Remove the device tree node of funnel@3023000
> to fix the warning. It will be added once the driver support to the
> source is added to linux kernel.

Thanks for the changes, but that's not correct reason to remove DTS
code. What kernel supports or not, should be irrelevant for the DTS. DTS
for example is used in other projects - did you check if they have the
same issues? Anyway, DTS describes the hardware, so how current kernel
support defines what is and what is not in the hardware?


Best regards,
Krzysztof