Re: [PATCH] dt-bindings: mfd: cros-ec: Allow interrupts-extended property

From: Krzysztof Kozlowski
Date: Thu Nov 30 2023 - 03:52:59 EST


On 30/11/2023 09:33, Chen-Yu Tsai wrote:
> "interrupts-extended" provides a more concise way of describing external
> GPIO interrupts.
>
> Allow using this instead of "interrupts" plus "interrupt-parent" for
> cros-ec.
>
> Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/google,cros-ec.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> index e1ca4f297c6d..e514eac9f4fc 100644
> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> @@ -75,6 +75,9 @@ properties:
> interrupts:
> maxItems: 1
>
> + interrupts-extended:
> + maxItems: 1
> +

I don't understand why you need it. You already have interrupts there,
so this is redundant. I suggest to drop the patch or provide real
rationale (which I doubt you can get :) ).

Best regards,
Krzysztof