RE: [PATCH net-next 1/2] ptp: introduce PTP_CLOCK_EXTOFF event for the measured external offset

From: Min Li
Date: Wed Nov 29 2023 - 11:59:50 EST


> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: November 28, 2023 10:58 PM
> To: Min Li <lnimi@xxxxxxxxxxx>
> Cc: richardcochran@xxxxxxxxx; lee@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Min Li
> <min.li.xe@xxxxxxxxxxx>
> Subject: Re: [PATCH net-next 1/2] ptp: introduce PTP_CLOCK_EXTOFF event
> for the measured external offset
>
> On Mon, 27 Nov 2023 15:01:29 -0500 Min Li wrote:
> > This change is for the PHC devices that can measure the phase offset
> > between PHC signal and the external signal, such as the 1PPS signal of
> > GNSS. Reporting PTP_CLOCK_EXTOFF to user space will be piggy-backed to
> > the existing ptp_extts_event so that application such as ts2phc can
> > poll the external offset the same way as extts. Hence, ts2phc can use
> > the offset to achieve the alignment between PHC and the external
> > signal by the help of either SW or HW filters.
>
> Does not apply to net-next.

Hi Jakub

I submitted an RFC last week and Richard was asking me to submit it together with a driver change as an example to implement it. Below is
Richard's quote

"Yes, the new option must wait for a driver that implements it. Can you make a patch series where the driver change appears in the second patch?"

But the driver that I submitted is a brand new PHC driver. So I don't know if it is appropriate to separate them to net and net-next? Because the driver
change depends on the this patch.

Min