[PATCH v3 1/2] thermal: trip: Drop a redundant check from thermal_zone_set_trip()

From: Rafael J. Wysocki
Date: Wed Nov 29 2023 - 08:39:15 EST


From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

After recent changes in the thermal framework, a trip points array is
required for registering a thermal zone that is not tripless, so the
tz->trips pointer in thermal_zone_set_trip() is never NULL and the
check involving it is redundant. Drop that check.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>
---

v2 -> v3: Add the tag from Lukasz

v1 -> v2: New patch

---
drivers/thermal/thermal_trip.c | 3 ---
1 file changed, 3 deletions(-)

Index: linux-pm/drivers/thermal/thermal_trip.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_trip.c
+++ linux-pm/drivers/thermal/thermal_trip.c
@@ -153,9 +153,6 @@ int thermal_zone_set_trip(struct thermal
struct thermal_trip t;
int ret;

- if (!tz->ops->set_trip_temp && !tz->ops->set_trip_hyst && !tz->trips)
- return -EINVAL;
-
ret = __thermal_zone_get_trip(tz, trip_id, &t);
if (ret)
return ret;