Re: [EXTERNAL] Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

From: Donald Robson
Date: Wed Nov 29 2023 - 07:15:54 EST


On Wed, 2023-11-29 at 13:04 +0100, Arnd Bergmann wrote:
> *** CAUTION: This email originates from a source not known to Imagination Technologies. Think before you click a link or open an attachment ***
>
> On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote:
> > Hello Arnd,
> >
> > Thanks for the patch. I'm slightly concerned that we've not seen this
> > warning when
> > building here. I guess we need to check our CI settings...
> >
> > Reviewed-by: Donald Robson <donald.robson@xxxxxxxxxx>
>
> This was previously enabled only when building with either
> "make W=1" or "make C=1", but not the default build, which
> explains why it only showed up after the merge into linux-next
> that has the corresponding scripts/Makefile.extrawarn change.
>
> It would still be a good idea to add the extra compiler (W=1)
> and sparse (C=1) warnings in your CI system and address all
> other issues that might uncover.
>
> Arnd

Thanks Arnd, we will do this.