Re: [PATCH] btrfs: fix btrfs_parse_param() build failure

From: David Sterba
Date: Wed Nov 29 2023 - 07:03:01 EST


On Wed, Nov 29, 2023 at 01:00:29PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> With CONFIG_BTRFS_FS_POSIX_ACL disabled, the newly added function fails
> to build because of an apparent broken rebase:
>
> fs/btrfs/super.c: In function 'btrfs_parse_param':
> fs/btrfs/super.c:416:25: error: 'ret' undeclared (first use in this function); did you mean 'net'?
> 416 | ret = -EINVAL;
> | ^~~
>
> Just return the error directly here instead of the incorrect unwinding.
>
> Fixes: a7293bf27082 ("btrfs: add parse_param callback for the new mount api")
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Should be fixed in today's for-next snapshot, thanks.