Re: [PATCH 2/2] nvme: prevent potential spectre v1 gadget

From: Dan Carpenter
Date: Wed Nov 29 2023 - 04:28:13 EST


On Tue, Nov 28, 2023 at 05:59:57PM +0530, Nitesh Shetty wrote:
> This patch fixes the smatch warning, "nvmet_ns_ana_grpid_store() warn:
> potential spectre issue 'nvmet_ana_group_enabled' [w] (local cap)"
> Prevent the contents of kernel memory from being leaked to user space
> via speculative execution by using array_index_nospec.
>
> Signed-off-by: Nitesh Shetty <nj.shetty@xxxxxxxxxxx>
> ---

When it comes to adding array_index_nospec(), then I don't know enough
about it to comment.

regards,
dan carpenter