Re: [PATCH v2 2/6] dt-bindings: riscv: Add StarFive JH8100 SoC

From: Krzysztof Kozlowski
Date: Wed Nov 29 2023 - 03:27:00 EST


On 29/11/2023 07:00, Sia Jee Heng wrote:
> Add device tree bindings for the StarFive JH8100 RISC-V SoC.
>
> Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/riscv/starfive.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> index cc4d92f0a1bf..7e2da9eef3db 100644
> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> @@ -29,7 +29,10 @@ properties:
> - starfive,visionfive-2-v1.2a
> - starfive,visionfive-2-v1.3b
> - const: starfive,jh7110
> -
> + - items:
> + - enum:
> + - starfive,jh8100-evb
> + - const: starfive,jh8100

Why did you remove the blank line? No need for doing that.

> additionalProperties: true
>
> ...

Best regards,
Krzysztof