RE: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device unload control net API

From: Shinas Rasheed
Date: Tue Nov 28 2023 - 23:42:42 EST




> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Wednesday, November 29, 2023 3:25 AM
> To: Shinas Rasheed <srasheed@xxxxxxxxxxx>
> >+ dev_info(&oct->pdev->dev, "Sending dev_unload msg to fw\n");
>
> Is it really necessary to print this at info level for each remove?
> Remove is a normal part of operation and we shouldn't spam logs
> unless we have a good reason..

I suppose it's not a need other than maybe for debug purposes. I'll use dev_dbg and submit a second version