Re: [PATCH v4 17/24] i2c: designware: Remove ->disable() callback

From: Andi Shyti
Date: Tue Nov 28 2023 - 19:48:38 EST


Hi Andy,

On Mon, Nov 20, 2023 at 04:41:59PM +0200, Andy Shevchenko wrote:
> Commit 90312351fd1e ("i2c: designware: MASTER mode as separated driver")
> introduced ->disable() callback but there is no real use for it. Both
> i2c-designware-master.c and i2c-designware-slave.c set it to the same
> i2c_dw_disable() and scope is inside the same kernel module.
>
> That said, replace the callback by explicitly calling the i2c_dw_disable().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Thanks,
Andi