Re: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for google,spherion

From: Christopher Obbard
Date: Tue Nov 28 2023 - 12:59:58 EST


Hi Nícolas,

On Mon, 2023-11-27 at 18:34 -0500, Nícolas F. R. A. Prado wrote:
> Add a sample board file describing the file's format and with the list
> of devices expected to be probed on the google,spherion machine as an
> example.

Did you consider using some machine-readable & extensible format like yaml?
Surely we don't need to invent yet-another file-format? :-)


Chris

>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> ---
>
> (no changes since v1)
>
>  .../testing/selftests/devices/boards/google,spherion | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 tools/testing/selftests/devices/boards/google,spherion
>
> diff --git a/tools/testing/selftests/devices/boards/google,spherion
> b/tools/testing/selftests/devices/boards/google,spherion
> new file mode 100644
> index 000000000000..db9a17cccd03
> --- /dev/null
> +++ b/tools/testing/selftests/devices/boards/google,spherion
> @@ -0,0 +1,12 @@
> +# Example test definition for Google Spherion Chromebook
> +#
> +# Format:
> +#   usb|pci test_name number_of_matches field=value [ field=value ... ]
> +#
> +# The available match fields vary by bus. The field-value match pairs for a
> +# device can be retrieved from the device's modalias attribute in sysfs. A
> +# subset of the fields may be used to make the match more generic so it can
> work
> +# with the different hardware variants of a device on the machine.
> +usb camera 1 ic=0e isc=01 ip=00
> +usb bluetooth 1 ic=e0 isc=01 ip=01 in=00
> +pci wifi 1 v=14c3 d=7961
> --
> 2.42.1
>
> _______________________________________________
> Kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxx