Re: [PATCH RESEND] x86/Kconfig: Remove obsolete config X86_32_SMP

From: Randy Dunlap
Date: Tue Nov 28 2023 - 11:28:25 EST




On 11/28/23 01:00, Lukas Bulwahn wrote:
> Commit 0f08c3b22996 ("x86/smp: Reduce code duplication") removes the only
> use of CONFIG_X86_32_SMP.
>
> Remove the obsolete config X86_32_SMP.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
>
> I sent this cleanup patch in March 2023 and it did not get any attention:
>
> https://lore.kernel.org/lkml/20230317101621.14413-1-lukas.bulwahn@xxxxxxxxx/
>
> It is just minor cleanup, but it also should not cause any issue.
> This can be quickly checked with grep "X86_32_SMP" . -R and seeing that
> this is only mentioned in arch/x86/Kconfig in this one definition.
>
> No change here other than rebasing the original patch.
>
> arch/x86/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 21890efbfdd8..d7d1ef3d2684 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -384,10 +384,6 @@ config HAVE_INTEL_TXT
> def_bool y
> depends on INTEL_IOMMU && ACPI
>
> -config X86_32_SMP
> - def_bool y
> - depends on X86_32 && SMP
> -
> config X86_64_SMP
> def_bool y
> depends on X86_64 && SMP

--
~Randy