Re: [PATCH v7 07/26] x86/fpu/xstate: Warn if kernel dynamic xfeatures detected in normal fpstate

From: Edgecombe, Rick P
Date: Tue Nov 28 2023 - 10:25:18 EST


On Fri, 2023-11-24 at 00:53 -0500, Yang Weijiang wrote:
> Kernel dynamic xfeatures now are __ONLY__ enabled for guest fpstate,
> i.e.,
> none for normal kernel fpstate. The bits are added when guest FPU
^never?
> config
> is initialized. Guest fpstate is allocated with fpstate->is_guest set
> to
> %true.
>
> For normal fpstate, the bits should have been removed when
> initializes
> kernel FPU config settings, WARN_ONCE() if kernel detects normal
> fpstate
> xfeatures contains kernel dynamic xfeatures before executes xsaves.
>
> Signed-off-by: Yang Weijiang <weijiang.yang@xxxxxxxxx>

Otherwise...

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>