Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails

From: Jonathan Cameron
Date: Tue Nov 28 2023 - 10:05:08 EST


On Tue, 07 Nov 2023 10:30:20 +0000
Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:

> From: James Morse <james.morse@xxxxxxx>
>
> loongarch, mips, parisc, riscv and sh all print a warning if
> register_cpu() returns an error. Architectures that use
> GENERIC_CPU_DEVICES call panic() instead.
>
> Errors in this path indicate something is wrong with the firmware
> description of the platform, but the kernel is able to keep running.
>
> Downgrade this to a warning to make it easier to debug this issue.
>
> This will allow architectures that switching over to GENERIC_CPU_DEVICES
> to drop their warning, but keep the existing behaviour.
>
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

I guess there may be paths later that were never exposed because of
this panic, but any such should be fixed rather than relying on this
big hammer.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>