Re: [PATCH] kconfig: WERROR unmet symbol dependency

[Masahiro Yamada]

On Tue, Nov 28, 2023 at 2:34 PM Sergey Senozhatsky
<senozhatsky@xxxxxxxxxxxx> wrote:
>
> On (23/11/22 12:47), Sergey Senozhatsky wrote:
> > When KCONFIG_WERROR env variable is set treat unmet direct
> > symbol dependency as a terminal condition (error).
> >
> > Suggested-by: Stefan Reinauer <reinauer@xxxxxxxxxx>
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
>
> Gentle ping.


I believe you know this patch is too cheesy to be accepted.



KCONFIG_WERROR is meant to turn all warnings
to errors.

I do not see getenv("KCONFIG_WERROR")
sprinkled everywhere in Kconfig.



One more thing, you cannot directly exit(1)
from sym_calc_value().

Curses programs (menuconfig / nconfig),
must call endwin() before exiting.

Otherwise, the terminal will not come back
to the canonical mode.


You do not need to fix it, though.








--
Best Regards
Masahiro Yamada