Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers

From: Michal Hocko
Date: Tue Nov 28 2023 - 05:01:24 EST


On Wed 22-11-23 18:25:07, Kent Overstreet wrote:
[...]
> +void shrinkers_to_text(struct seq_buf *out)
> +{
> + struct shrinker *shrinker;
> + struct shrinker_by_mem {
> + struct shrinker *shrinker;
> + unsigned long mem;
> + } shrinkers_by_mem[10];
> + int i, nr = 0;
> +
> + if (!mutex_trylock(&shrinker_mutex)) {
> + seq_buf_puts(out, "(couldn't take shrinker lock)");
> + return;
> + }
> +
> + list_for_each_entry(shrinker, &shrinker_list, list) {
> + struct shrink_control sc = { .gfp_mask = GFP_KERNEL, };

This seems to be global reclaim specific. What about memcg reclaim?
--
Michal Hocko
SUSE Labs