Re: [PATCH 1/3] Revert "driver core: Export device_is_dependent() to modules"

[Neil Armstrong]

On 28/11/2023 00:10, Linus Walleij wrote:
> This reverts commit 1d5e8f4bf06da86b71cc9169110d1a0e1e7af337.
>
> Greg says: "why exactly is this needed?  Nothing outside of
> the driver core should be needing this function, it shouldn't
> be public at all (I missed that before.)
>
> So please, revert it for now, let's figure out why DRM thinks
> this is needed for it's devices, and yet no other bus/subsystem
> does."
>
> Link: https://lore.kernel.org/dri-devel/2023112739-willing-sighing-6bdd@gregkh/
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>   drivers/base/core.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index bfd2bf0364b7..67ba592afc77 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -328,7 +328,6 @@ int device_is_dependent(struct device *dev, void *target)
>   	}
>   	return ret;
>   }
> -EXPORT_SYMBOL_GPL(device_is_dependent);
>   
>   static void device_link_init_status(struct device_link *link,
>   				    struct device *consumer,

Acked-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>