RE: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive

[JeeHeng Sia]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Tuesday, November 28, 2023 3:21 PM
> To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx;
> conor@xxxxxxxxxx; kernel@xxxxxxxx; robh+dt@xxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive
> 
> On 28/11/2023 06:25, JeeHeng Sia wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: Monday, November 27, 2023 4:49 PM
> >> To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx;
> >> conor@xxxxxxxxxx; kernel@xxxxxxxx; robh+dt@xxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx
> >> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> >> Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive
> >>
> >> On 27/11/2023 02:36, Sia Jee Heng wrote:
> >>> This patch adds the new compatible string for StarFive JH8100 SoC
> >>>
> >>> Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx>
> >>> Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> >>> ---
> >>>  drivers/tty/serial/xilinx_uartps.c | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> >>> index 66a45a634158..170901c143c2 100644
> >>> --- a/drivers/tty/serial/xilinx_uartps.c
> >>> +++ b/drivers/tty/serial/xilinx_uartps.c
> >>> @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup);
> >>>  OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup);
> >>>  OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup);
> >>>  OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup);
> >>> -
> >>> +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup);
> >>>
> >>>  /* Static pointer to console port */
> >>>  static struct uart_port *console_port;
> >>> @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = {
> >>>  	{ .compatible = "cdns,uart-r1p8", },
> >>>  	{ .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def },
> >>>  	{ .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def },
> >>> +	{ .compatible = "starfive,jh8100-uart", },
> >>
> >> Why you do not express compatibility in your bindings? Skip this driver
> >> change.
> > The compatibility string was added to the binding in the 5th patch. We need to add this compatibility string to the driver, as the
> other compatibilities were used for other SoCs.
> 
> You did not add "compatibility string" but compatible. I am asking why
> you are not expressing in your bindings the compatibility between this
> and other devices.
> 
> And no, you do not need driver change for compatible devices, so again:
> skip this driver change.
Alright, I will skip this driver change. Thanks.
> 
> 
> Best regards,
> Krzysztof