RE: [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint

From: JeeHeng Sia
Date: Tue Nov 28 2023 - 02:56:28 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Tuesday, November 28, 2023 3:20 PM
> To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx;
> conor@xxxxxxxxxx; kernel@xxxxxxxx; robh+dt@xxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint
>
> On 28/11/2023 06:24, JeeHeng Sia wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: Monday, November 27, 2023 4:48 PM
> >> To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx;
> >> conor@xxxxxxxxxx; kernel@xxxxxxxx; robh+dt@xxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx
> >> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> >> Subject: Re: [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint
> >>
> >> On 27/11/2023 02:35, Sia Jee Heng wrote:
> >>> Add compatible string for the StarFive JH8100 clint
> >>>
> >>> Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx>
> >>> Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> >>> ---
> >>
> >> Please use scripts/get_maintainers.pl to get a list of necessary people
> >> and lists to CC. It might happen, that command when run on an older
> >> kernel, gives you outdated entries. Therefore please be sure you base
> >> your patches on recent Linux kernel.
> >>
> >> You missed at least devicetree list (maybe more), so this won't be
> >> tested by automated tooling. Performing review on untested code might be
> >> a waste of time, thus I will skip this patch entirely till you follow
> >> the process allowing the patch to be tested.
> >>
> >> Please kindly resend and include all necessary To/Cc entries.
> > Noted. Should I resend the patches with the V1 tag and with addressed comments?
>
> This was v1. Next one is v2.
Noted with thanks.
>
> Best regards,
> Krzysztof