Re: [PATCH v5] PM: sleep: Expose last succeeded resumed timestamp in sysfs

From: Randy Dunlap
Date: Mon Nov 27 2023 - 18:47:44 EST


Hi--


On 11/27/23 02:38, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>

> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index f6425ae3e8b0..2ab23fd3daac 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c

> @@ -514,6 +526,9 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
> suspend_step_name(
> suspend_stats.failed_steps[index]));
> }
> + seq_printf(s, "last_success_resume_time:\t%-llu.%llu\n",

The <TAB> after "s," is a bit odd IMO, but I don't see a need to resend it
just for that.

> + (unsigned long long)suspend_stats.last_success_resume_time.tv_sec,
> + (unsigned long long)suspend_stats.last_success_resume_time.tv_nsec);
>
> return 0;
> }

--
~Randy