Re: [PATCH] mtd: spi-nor: stop printing superfluous debug info

From: Miquel Raynal
Date: Mon Nov 27 2023 - 12:15:27 EST


Hi Tudor,

tudor.ambarus@xxxxxxxxxx wrote on Mon, 27 Nov 2023 16:59:08 +0000:

> The mtd data can be obtain with the mtd ioctls and the SPI NOR
> flash name can be determined interrogating the sysfs entries.
> Stop polluting the kernel log.

Actually I like these prints when developing/fixing stuff, it's a clear
indication of what's been discovered that is available even if for some
reason my rootfs is not available (which is common when the rootfs is
on a spi-nor).

So I would not trash all these lines personally... I believe the
dev_info can be lowered if you prefer, but dev_dbg is already meant for
debugging purposes and will anyway be discarded by default.

> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---
> drivers/mtd/spi-nor/core.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 25a64c65717d..6de76fd009d1 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3517,25 +3517,6 @@ int spi_nor_scan(struct spi_nor *nor, const char *name,
> /* No mtd_info fields should be used up to this point. */
> spi_nor_set_mtd_info(nor);
>
> - dev_info(dev, "%s (%lld Kbytes)\n", info->name,
> - (long long)mtd->size >> 10);
> -
> - dev_dbg(dev,
> - "mtd .name = %s, .size = 0x%llx (%lldMiB), "
> - ".erasesize = 0x%.8x (%uKiB) .numeraseregions = %d\n",
> - mtd->name, (long long)mtd->size, (long long)(mtd->size >> 20),
> - mtd->erasesize, mtd->erasesize / 1024, mtd->numeraseregions);
> -
> - if (mtd->numeraseregions)
> - for (i = 0; i < mtd->numeraseregions; i++)
> - dev_dbg(dev,
> - "mtd.eraseregions[%d] = { .offset = 0x%llx, "
> - ".erasesize = 0x%.8x (%uKiB), "
> - ".numblocks = %d }\n",
> - i, (long long)mtd->eraseregions[i].offset,
> - mtd->eraseregions[i].erasesize,
> - mtd->eraseregions[i].erasesize / 1024,
> - mtd->eraseregions[i].numblocks);
> return 0;
> }
> EXPORT_SYMBOL_GPL(spi_nor_scan);


Thanks,
Miquèl