Re: [PATCH net-next v5 01/14] page_pool: make sure frag API fields don't span between cachelines

From: Alexander Lobakin
Date: Mon Nov 27 2023 - 09:18:20 EST


From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Sun, 26 Nov 2023 14:54:57 -0800

> On Fri, 24 Nov 2023 16:47:19 +0100 Alexander Lobakin wrote:
>> - long frag_users;
>> + long frag_users __aligned(4 * sizeof(long));
>
> A comment for the somewhat unusual alignment size would be good.

Roger that. Will paste a couple words from the commit message.

FYI, I had an idea of doing something like

__aligned(roundup_pow_of_2(2 * sizeof(long) + 2 * sizeof(int)))

but that looks horrible, so I stopped on the current :D There are no
functional changes between them either way.

Thanks,
Olek