Re: [PATCH 5/5] mei: pxp: add dependency on Xe driver

From: Greg Kroah-Hartman
Date: Mon Nov 27 2023 - 08:54:45 EST


On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> >
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> > > ---
> > > drivers/misc/mei/pxp/Kconfig | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> >
> > Why this change here?
>
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.
> I can drop this change if it is inappropriate to put it in this patch.

It should not go into this patch. Remember, each patch should only do
"one thing".

thanks,

greg k-h