Re: [PATCH 6/9] arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool

[AngeloGioacchino Del Regno]

Il 27/11/23 05:00, Chen-Yu Tsai ha scritto:
> On Mon, Oct 23, 2023 at 5:05 PM Eugen Hristev
> <eugen.hristev@xxxxxxxxxxxxx> wrote:
> > On 10/13/23 02:02, Chen-Yu Tsai wrote:
> > > Tentacruel and Tentacool are MT8186 based Chromebooks based on the
> > > Krabby design.
> > >
> > > Tentacruel, also known as the ASUS Chromebook CM14 Flip CM1402F, is a
> > > convertible device with touchscreen and stylus.
> > >
> > > Tentacool, also known as the ASUS Chromebook CM14 CM1402C, is a laptop
> > > device. It does not have a touchscreen or stylus.
> > >
> > > The two devices both have two variants. The difference is a second
> > > source touchpad controller that shares the same address as the original,
> > > but is incompatible.
> > >
> > > The extra SKU IDs for the Tentacruel devices map to different sensor
> > > components attached to the Embedded Controller. These are not visible
> > > to the main processor.
> > >
> > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> > > ---
> > >    arch/arm64/boot/dts/mediatek/Makefile         |    4 +
> > >    .../dts/mediatek/mt8186-corsola-krabby.dtsi   |  130 ++
> > >    .../mt8186-corsola-tentacool-sku327681.dts    |   49 +
> > >    .../mt8186-corsola-tentacool-sku327683.dts    |   26 +
> > >    .../mt8186-corsola-tentacruel-sku262144.dts   |   44 +
> > >    .../mt8186-corsola-tentacruel-sku262148.dts   |   28 +
> > >    .../boot/dts/mediatek/mt8186-corsola.dtsi     | 1704 +++++++++++++++++
> > >    7 files changed, 1985 insertions(+)
> > >    create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-krabby.dtsi
> > >    create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327681.dts
> > >    create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts
> > >    create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262144.dts
> > >    create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts
> > >    create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>
> [...]
>
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> > > new file mode 100644
> > > index 000000000000..42ebab1bafeb
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> > > @@ -0,0 +1,1704 @@
>
> [...]
>
> > Hi Chen-Yu,
> >
> > These two aud_gpio_tdm empty entries cause this message to be printed:
> >
> > [   12.949519] mt8186_mt6366_rt1019_rt5682s sound: there is not valid
> > maps for state aud_gpio_tdm_off
> > [   12.959025] mt8186_mt6366_rt1019_rt5682s sound: there is not valid
> > maps for state aud_gpio_tdm_on
>
> I guess we need to teach the sound driver to ignore empty pinmux states?

...and we need to teach to the bindings that the aud_gpio_tdm_{off,on} are
optional states and can be omitted.

Cheers,
Angelo

> ChenYu