Re: [PATCH] arm64: dts: rockchip: Add dynamic-power-coefficient to rk3399 GPU

[Chen-Yu Tsai]

On Mon, Nov 27, 2023 at 4:14 PM Lukasz Luba <lukasz.luba@xxxxxxx> wrote:
>
> Add dynamic-power-coefficient to the GPU node. That will create Energy
> Model for the GPU based on the coefficient and OPP table information.
> It will enable mechanism such as DTMP or IPA to work with the GPU DVFS.
> In similar way the Energy Model for CPUs in rk3399 is created, so both
> are aligned in power scale. The maximum power used from this coefficient
> is 1.5W at 600MHz.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 9da0b6d77c8d..87cfdf570b19 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -2113,6 +2113,7 @@ gpu: gpu@ff9a0000 {
>                 interrupt-names = "job", "mmu", "gpu";
>                 clocks = <&cru ACLK_GPU>;
>                 #cooling-cells = <2>;
> +               dynamic-power-coefficient = <2640>;

For reference, in the ChromeOS downstrean v5.10 kernel we have:

gpu_power_model: power_model {
        compatible = "arm,mali-simple-power-model";
        static-coefficient = <411522>;
        dynamic-coefficient = <977>;
        ts = <32000 4700 (-80) 2>;
        thermal-zone = "gpu";
};

This is for the Mali kbase.

ChenYu

>                 power-domains = <&power RK3399_PD_GPU>;
>                 status = "disabled";
>         };
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel