Re: [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate

From: Greg KH
Date: Sun Nov 26 2023 - 05:29:24 EST


On Sat, Nov 25, 2023 at 05:34:31PM -0500, Gary Rookard wrote:
> -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
> +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 n_data_rate)

Why are you keeping the "n"? It's not needed, right? Remember, these
were written in "Hungarian notation" which uses the variable name to
denote the type of the variable, so "n" means "number" perhaps? So it
can be dropped.

thanks,

greg k-h