Re: [PATCH] hwmon: sht3x: read out sensor serial number

From: Guenter Roeck
Date: Sat Nov 25 2023 - 19:04:25 EST


On Fri, Nov 24, 2023 at 11:09:31PM +0100, Stefan Gloor wrote:
> Hi Guenter,
>
> thank you for your comments.
>
> On Fri, Nov 24, 2023 at 09:34:48AM -0800, Guenter Roeck wrote:
> > I am not going to accept this as sysfs attribute. Please implement
> > using debugfs.
> >
> I will do this in V2.
>
> >
> > Also, the attribute (sysfs or debugfs) should not exist if not supported.
> > Please only provide if supported.
> The driver is currently only compatible with "sht3x" and "sts3x".
> As only a subset of these support this feature, do you recommend I
> create new additional device IDs, i.e., sts32, sts33 and sht33?
>

If they have different functionality, they need different IDs.

Guenter

> Best,
> Stefan
> --
>