Re: [PATCH] gpiolib: Drop cargo-culted comment

From: Linus Walleij
Date: Sat Nov 25 2023 - 18:05:29 EST


On Sat, Nov 25, 2023 at 3:40 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> On Sat, Nov 25, 2023 at 12:25:47AM +0100, Linus Walleij wrote:

> > -/* gpio_lock prevents conflicts during gpio_desc[] table updates.
> > - * While any GPIO is requested, its gpio_chip is not removable;
> > - * each GPIO's "requested" flag serves as a lock and refcount.
> > - */
>
> Perhaps provide a comment as to what the gpio_lock DOES cover?

Normally yes, but Bartosz just said he is going to replace this spinlock
with a mutex so it's better if he adds it then.

Yours,
Linus Walleij