Re: [PATCH v2 7/7] iio: adc: ad7091r-base: Add debugfs reg access

From: Jonathan Cameron
Date: Sat Nov 25 2023 - 11:44:17 EST


On Thu, 23 Nov 2023 13:43:06 -0300
Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:

> Add direct register access support for AD7091R-2/-4/-5/-8 ADCs.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>

regmap provides it's own version of this, so I'm not sure I'd bother adding
the IIO one. See regmap-debugfs.c


> ---
> drivers/iio/adc/ad7091r-base.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
> index dbc60ea1bafc..4d5051316428 100644
> --- a/drivers/iio/adc/ad7091r-base.c
> +++ b/drivers/iio/adc/ad7091r-base.c
> @@ -177,8 +177,20 @@ static int ad7091r_read_raw(struct iio_dev *iio_dev,
> return ret;
> }
>
> +static int ad7091r_reg_access(struct iio_dev *indio_dev, unsigned int reg,
> + unsigned int writeval, unsigned int *readval)
> +{
> + struct ad7091r_state *st = iio_priv(indio_dev);
> +
> + if (readval)
> + return regmap_read(st->map, reg, readval);
> +
> + return regmap_write(st->map, reg, writeval);
> +}
> +
> static const struct iio_info ad7091r_info = {
> .read_raw = ad7091r_read_raw,
> + .debugfs_reg_access = &ad7091r_reg_access,
> };
>
> static irqreturn_t ad7091r_event_handler(int irq, void *private)