Re: [PATCH v2] riscv: fix incorrect use of __user pointer

From: Christoph Hellwig
Date: Sat Nov 25 2023 - 01:23:30 EST


On Fri, Nov 24, 2023 at 12:38:03PM +0100, Clément Léger wrote:
>
> #ifdef CONFIG_RISCV_M_MODE
> -static inline int load_u8(struct pt_regs *regs, const u8 *addr, u8 *r_val)
> +static inline int load_u8(struct pt_regs *regs, const unsigned long addr, u8 *r_val)

Please avoid the overly long line here. Or just drop the const as that
is rather pointless for a scalaer (unlike the pointer).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>