Re: [PATCH 5.15 000/297] 5.15.140-rc1 review

From: Daniel Díaz
Date: Fri Nov 24 2023 - 18:26:02 EST


Hello!

On 24/11/23 11:50 a. m., Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.15.140 release.
There are 297 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun, 26 Nov 2023 17:19:17 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.140-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
and the diffstat can be found below.

thanks,

greg k-h

There are problems with PA-RISC:

-----8<-----
/builds/linux/drivers/parisc/power.c:201:34: warning: 'struct sys_off_data' declared inside parameter list will not be visible outside of this definition or declaration
201 | static int qemu_power_off(struct sys_off_data *data)
| ^~~~~~~~~~~~
/builds/linux/drivers/parisc/power.c: In function 'qemu_power_off':
/builds/linux/drivers/parisc/power.c:204:43: error: invalid use of undefined type 'struct sys_off_data'
204 | gsc_writel(0, (unsigned long) data->cb_data);
| ^~
/builds/linux/drivers/parisc/power.c: In function 'power_init':
/builds/linux/drivers/parisc/power.c:239:17: error: implicit declaration of function 'register_sys_off_handler'; did you mean 'register_restart_handler'? [-Werror=implicit-function-declaration]
239 | register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT,
| ^~~~~~~~~~~~~~~~~~~~~~~~
| register_restart_handler
/builds/linux/drivers/parisc/power.c:239:42: error: 'SYS_OFF_MODE_POWER_OFF' undeclared (first use in this function); did you mean 'SYSTEM_POWER_OFF'?
239 | register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT,
| ^~~~~~~~~~~~~~~~~~~~~~
| SYSTEM_POWER_OFF
/builds/linux/drivers/parisc/power.c:239:42: note: each undeclared identifier is reported only once for each function it appears in
/builds/linux/drivers/parisc/power.c:239:66: error: 'SYS_OFF_PRIO_DEFAULT' undeclared (first use in this function)
239 | register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT,
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [/builds/linux/scripts/Makefile.build:289: drivers/parisc/power.o] Error 1
----->8-----

That's allnoconfig with GCC 11; defconfig and tinyconfig fail just like that.

Bisection points to:

commit 065a7d0b92c0f1ef4160e2129d835eb6093cc675
Author: Helge Deller <deller@xxxxxx>
Date: Tue Oct 17 22:19:53 2023 +0200

parisc/power: Add power soft-off when running on qemu
commit d0c219472980d15f5cbc5c8aec736848bda3f235 upstream.


Then there's this failure on System/390:

-----8<-----
/builds/linux/arch/s390/mm/page-states.c: In function 'mark_kernel_pgd':
/builds/linux/arch/s390/mm/page-states.c:175:38: error: request for member 'val' in something not a structure or union
max_addr = (S390_lowcore.kernel_asce.val & _ASCE_TYPE_MASK) >> 2;
^
In file included from /builds/linux/arch/s390/include/asm/page.h:186,
from /builds/linux/arch/s390/include/asm/thread_info.h:26,
from /builds/linux/include/linux/thread_info.h:60,
from /builds/linux/arch/s390/include/asm/preempt.h:6,
from /builds/linux/include/linux/preempt.h:78,
from /builds/linux/include/linux/spinlock.h:55,
from /builds/linux/include/linux/mmzone.h:8,
from /builds/linux/include/linux/gfp.h:6,
from /builds/linux/include/linux/mm.h:10,
from /builds/linux/arch/s390/mm/page-states.c:13:
/builds/linux/arch/s390/mm/page-states.c: In function 'cmma_init_nodat':
/builds/linux/arch/s390/mm/page-states.c:204:23: error: 'invalid_pg_dir' undeclared (first use in this function); did you mean 'is_valid_bugaddr'?
page = virt_to_page(&invalid_pg_dir);
^~~~~~~~~~~~~~
/builds/linux/include/asm-generic/memory_model.h:25:40: note: in definition of macro '__pfn_to_page'
#define __pfn_to_page(pfn) (vmemmap + (pfn))
^~~
/builds/linux/arch/s390/include/asm/page.h:176:29: note: in expansion of macro 'phys_to_pfn'
#define virt_to_pfn(kaddr) (phys_to_pfn(__pa(kaddr)))
^~~~~~~~~~~
/builds/linux/arch/s390/include/asm/page.h:176:41: note: in expansion of macro '__pa'
#define virt_to_pfn(kaddr) (phys_to_pfn(__pa(kaddr)))
^~~~
/builds/linux/arch/s390/include/asm/page.h:179:41: note: in expansion of macro 'virt_to_pfn'
#define virt_to_page(kaddr) pfn_to_page(virt_to_pfn(kaddr))
^~~~~~~~~~~
/builds/linux/arch/s390/mm/page-states.c:204:9: note: in expansion of macro 'virt_to_page'
page = virt_to_page(&invalid_pg_dir);
^~~~~~~~~~~~
/builds/linux/arch/s390/mm/page-states.c:204:23: note: each undeclared identifier is reported only once for each function it appears in
page = virt_to_page(&invalid_pg_dir);
^~~~~~~~~~~~~~
/builds/linux/include/asm-generic/memory_model.h:25:40: note: in definition of macro '__pfn_to_page'
#define __pfn_to_page(pfn) (vmemmap + (pfn))
^~~
/builds/linux/arch/s390/include/asm/page.h:176:29: note: in expansion of macro 'phys_to_pfn'
#define virt_to_pfn(kaddr) (phys_to_pfn(__pa(kaddr)))
^~~~~~~~~~~
/builds/linux/arch/s390/include/asm/page.h:176:41: note: in expansion of macro '__pa'
#define virt_to_pfn(kaddr) (phys_to_pfn(__pa(kaddr)))
^~~~
/builds/linux/arch/s390/include/asm/page.h:179:41: note: in expansion of macro 'virt_to_pfn'
#define virt_to_page(kaddr) pfn_to_page(virt_to_pfn(kaddr))
^~~~~~~~~~~
/builds/linux/arch/s390/mm/page-states.c:204:9: note: in expansion of macro 'virt_to_page'
page = virt_to_page(&invalid_pg_dir);
^~~~~~~~~~~~
make[3]: *** [/builds/linux/scripts/Makefile.build:289: arch/s390/mm/page-states.o] Error 1
----->8-----

Bisection in this case points to:

commit d247caa47712c9cc36f25ec744f3b5dba90c3334
Author: Heiko Carstens <hca@xxxxxxxxxxxxx>
Date: Tue Oct 17 21:07:03 2023 +0200

s390/cmma: fix initial kernel address space page table walk
commit 16ba44826a04834d3eeeda4b731c2ea3481062b7 upstream.


Reproducers:

tuxmake --runtime podman --target-arch parisc --toolchain gcc-11 --kconfig allnoconfig

and

tuxmake --runtime podman --target-arch s390 --toolchain gcc-8 --kconfig allnoconfig


Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>

Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx