Re: [PATCH net-next v3] firmware_loader: Expand Firmware upload error codes with firmware invalid error

From: Simon Horman
Date: Fri Nov 24 2023 - 11:48:43 EST


On Wed, Nov 22, 2023 at 02:52:43PM +0100, Kory Maincent wrote:
> No error code are available to signal an invalid firmware content.
> Drivers that can check the firmware content validity can not return this
> specific failure to the user-space
>
> Expand the firmware error code with an additional code:
> - "firmware invalid" code which can be used when the provided firmware
> is invalid
>
> Sync lib/test_firmware.c file accordingly.
>
> Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
>
> Changes in v3:
> - Add the newly introduced error code to test_firmware.c

I verified that the error obvserved in v2 when compiling the above
file with clang-16 has been resolved.

Link: https://lore.kernel.org/all/20231121173022.3cb2fcad@xxxxxxxxxx/

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

...