Re: [PATCH 2/2] leds: add mp3326 driver
From: kernel test robot
Date: Fri Nov 24 2023 - 10:43:37 EST
Hi Yuxi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on robh/for-next linus/master v6.7-rc2 next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yuxi-Wang/dt-bindings-leds-add-mps-mp3326-LED/20231124-173610
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/20231124093034.951-3-Yuxi.Wang%40monolithicpower.com
patch subject: [PATCH 2/2] leds: add mp3326 driver
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20231124/202311242100.FGwL3wE0-lkp@xxxxxxxxx/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231124/202311242100.FGwL3wE0-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311242100.FGwL3wE0-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/leds/leds-mp3326.c: In function 'mp3326_parse_dt':
>> drivers/leds/leds-mp3326.c:543:13: warning: unused variable 'val' [-Wunused-variable]
543 | int val;
| ^~~
drivers/leds/leds-mp3326.c: At top level:
drivers/leds/leds-mp3326.c:611:10: error: 'struct i2c_driver' has no member named 'probe_new'
611 | .probe_new = mp3326_leds_probe,
| ^~~~~~~~~
drivers/leds/leds-mp3326.c:611:22: warning: initialization of 'unsigned int' from 'int (*)(struct i2c_client *)' makes integer from pointer without a cast [-Wint-conversion]
611 | .probe_new = mp3326_leds_probe,
| ^~~~~~~~~~~~~~~~~
drivers/leds/leds-mp3326.c:611:22: note: (near initialization for 'mp3326_driver.class')
vim +/val +543 drivers/leds/leds-mp3326.c
536
537 static int mp3326_parse_dt(struct mp3326 *chip)
538 {
539 struct device_node *np = dev_of_node(&chip->client->dev);
540 struct device_node *child;
541 int ret;
542 int i = 0;
> 543 int val;
544
545 for_each_available_child_of_node(np, child) {
546 ret = mp3326_add_led(chip, child, i);
547 if (ret)
548 return ret;
549 i++;
550 }
551
552 ret = regmap_write(chip->regmap, MP3326_PWM_CTRL_CHANNEL_9_16, 0);
553 if (ret)
554 return ret;
555 ret = regmap_write(chip->regmap, MP3326_PWM_CTRL_CHANNEL_1_8, 0);
556 if (ret)
557 return ret;
558 return 0;
559 }
560
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki