Re: [PATCH] video: fbdev: mmp: Fix typo in code comment

From: Randy Dunlap
Date: Fri Nov 24 2023 - 10:34:34 EST


Hi,

On 11/24/23 01:52, Dario Binacchi wrote:
> s/singals/signals/
>
> Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller")
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> index 16401eb95c6c..64e34b7e739e 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_spi.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> @@ -91,7 +91,7 @@ static int lcd_spi_setup(struct spi_device *spi)
> writel(tmp, reg_base + LCD_SPU_SPI_CTRL);
>
> /*
> - * After set mode it need a time to pull up the spi singals,
> + * After set mode it need a time to pull up the spi signals,

Also:
it needs time
or
it needs some time

> * or it would cause the wrong waveform when send spi command,
> * especially on pxa910h
> */

thanks.
--
~Randy