Re: [PATCH v3 03/21] dentry: switch the lists of children to hlist

From: Al Viro
Date: Fri Nov 24 2023 - 02:55:18 EST


On Fri, Nov 24, 2023 at 09:44:27AM +0200, Amir Goldstein wrote:
> On Fri, Nov 24, 2023 at 8:05 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Saves a pointer per struct dentry and actually makes the things less
> > clumsy. Cleaned the d_walk() and dcache_readdir() a bit by use
> > of hlist_for_... iterators.
> >
> > A couple of new helpers - d_first_child() and d_next_sibling(),
> > to make the expressions less awful.
> >
> > X-fuck-kABI: gladly
>
> ???

It breaks kABI. Hard. For a good reason. And if you need an elaboration
of the reasons why kABI is, er, not universally liked - let's take it
to private email. Some rants are really too unprintable for maillists...