Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support

From: Andrew Lunn
Date: Thu Nov 23 2023 - 15:05:10 EST


> @@ -702,6 +718,10 @@ int stmmac_get_platform_resources(struct platform_device *pdev,
> if (stmmac_res->irq < 0)
> return stmmac_res->irq;
>
> + ret = stmmac_get_fault_intr_config(pdev, stmmac_res);
> + if (ret)
> + dev_err(&pdev->dev, "Fault interrupt not present\n");

This fault/saftey/foobar interrupt is optional? So printing any error
message it is missing does not seem like a good idea.

Andrew