Re: [syzbot] [usb?] [staging?] memory leak in _r8712_init_xmit_priv (2)

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in _r8712_init_xmit_priv

BUG: memory leak
unreferenced object 0xffff8881085a3000 (size 4096):
  comm "kworker/0:5", pid 5051, jiffies 4294944413 (age 8.790s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81633f0d>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff81633f0d>] slab_post_alloc_hook mm/slab.h:766 [inline]
    [<ffffffff81633f0d>] slab_alloc_node mm/slub.c:3478 [inline]
    [<ffffffff81633f0d>] __kmem_cache_alloc_node+0x2dd/0x3f0 mm/slub.c:3517
    [<ffffffff8157ed95>] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098
    [<ffffffff83cef2a1>] kmalloc include/linux/slab.h:600 [inline]
    [<ffffffff83cef2a1>] _r8712_init_xmit_priv+0x2c1/0x6f0 drivers/staging/rtl8712/rtl871x_xmit.c:131
    [<ffffffff83ce9e83>] r8712_init_drv_sw+0xc3/0x290 drivers/staging/rtl8712/os_intfs.c:311
    [<ffffffff83ce8b36>] r871xu_drv_init+0x1c6/0x920 drivers/staging/rtl8712/usb_intf.c:386
    [<ffffffff832d15eb>] usb_probe_interface+0x16b/0x3a0 drivers/usb/core/driver.c:396
    [<ffffffff82c3c336>] call_driver_probe drivers/base/dd.c:579 [inline]
    [<ffffffff82c3c336>] really_probe+0x126/0x440 drivers/base/dd.c:658
    [<ffffffff82c3c713>] __driver_probe_device+0xc3/0x190 drivers/base/dd.c:800
    [<ffffffff82c3c80a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:830
    [<ffffffff82c3ca04>] __device_attach_driver+0x104/0x160 drivers/base/dd.c:958
    [<ffffffff82c3978d>] bus_for_each_drv+0xcd/0x120 drivers/base/bus.c:457
    [<ffffffff82c3cf2a>] __device_attach+0xfa/0x290 drivers/base/dd.c:1030
    [<ffffffff82c3aefa>] bus_probe_device+0xca/0xd0 drivers/base/bus.c:532
    [<ffffffff82c373ae>] device_add+0x9be/0xc90 drivers/base/core.c:3625
    [<ffffffff832ce6b7>] usb_set_configuration+0x967/0xc70 drivers/usb/core/message.c:2207
    [<ffffffff832e138c>] usb_generic_driver_probe+0x9c/0xf0 drivers/usb/core/generic.c:238

BUG: memory leak
unreferenced object 0xffff8881085a5000 (size 4096):
  comm "kworker/0:5", pid 5051, jiffies 4294944413 (age 8.790s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81633f0d>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff81633f0d>] slab_post_alloc_hook mm/slab.h:766 [inline]
    [<ffffffff81633f0d>] slab_alloc_node mm/slub.c:3478 [inline]
    [<ffffffff81633f0d>] __kmem_cache_alloc_node+0x2dd/0x3f0 mm/slub.c:3517
    [<ffffffff8157ed95>] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098
    [<ffffffff83cef2a1>] kmalloc include/linux/slab.h:600 [inline]
    [<ffffffff83cef2a1>] _r8712_init_xmit_priv+0x2c1/0x6f0 drivers/staging/rtl8712/rtl871x_xmit.c:131
    [<ffffffff83ce9e83>] r8712_init_drv_sw+0xc3/0x290 drivers/staging/rtl8712/os_intfs.c:311
    [<ffffffff83ce8b36>] r871xu_drv_init+0x1c6/0x920 drivers/staging/rtl8712/usb_intf.c:386
    [<ffffffff832d15eb>] usb_probe_interface+0x16b/0x3a0 drivers/usb/core/driver.c:396
    [<ffffffff82c3c336>] call_driver_probe drivers/base/dd.c:579 [inline]
    [<ffffffff82c3c336>] really_probe+0x126/0x440 drivers/base/dd.c:658
    [<ffffffff82c3c713>] __driver_probe_device+0xc3/0x190 drivers/base/dd.c:800
    [<ffffffff82c3c80a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:830
    [<ffffffff82c3ca04>] __device_attach_driver+0x104/0x160 drivers/base/dd.c:958
    [<ffffffff82c3978d>] bus_for_each_drv+0xcd/0x120 drivers/base/bus.c:457
    [<ffffffff82c3cf2a>] __device_attach+0xfa/0x290 drivers/base/dd.c:1030
    [<ffffffff82c3aefa>] bus_probe_device+0xca/0xd0 drivers/base/bus.c:532
    [<ffffffff82c373ae>] device_add+0x9be/0xc90 drivers/base/core.c:3625
    [<ffffffff832ce6b7>] usb_set_configuration+0x967/0xc70 drivers/usb/core/message.c:2207
    [<ffffffff832e138c>] usb_generic_driver_probe+0x9c/0xf0 drivers/usb/core/generic.c:238

BUG: memory leak
unreferenced object 0xffff8881085a7000 (size 4096):
  comm "kworker/0:5", pid 5051, jiffies 4294944414 (age 8.780s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81633f0d>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff81633f0d>] slab_post_alloc_hook mm/slab.h:766 [inline]
    [<ffffffff81633f0d>] slab_alloc_node mm/slub.c:3478 [inline]
    [<ffffffff81633f0d>] __kmem_cache_alloc_node+0x2dd/0x3f0 mm/slub.c:3517
    [<ffffffff8157ed95>] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098
    [<ffffffff83cef2a1>] kmalloc include/linux/slab.h:600 [inline]
    [<ffffffff83cef2a1>] _r8712_init_xmit_priv+0x2c1/0x6f0 drivers/staging/rtl8712/rtl871x_xmit.c:131
    [<ffffffff83ce9e83>] r8712_init_drv_sw+0xc3/0x290 drivers/staging/rtl8712/os_intfs.c:311
    [<ffffffff83ce8b36>] r871xu_drv_init+0x1c6/0x920 drivers/staging/rtl8712/usb_intf.c:386
    [<ffffffff832d15eb>] usb_probe_interface+0x16b/0x3a0 drivers/usb/core/driver.c:396
    [<ffffffff82c3c336>] call_driver_probe drivers/base/dd.c:579 [inline]
    [<ffffffff82c3c336>] really_probe+0x126/0x440 drivers/base/dd.c:658
    [<ffffffff82c3c713>] __driver_probe_device+0xc3/0x190 drivers/base/dd.c:800
    [<ffffffff82c3c80a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:830
    [<ffffffff82c3ca04>] __device_attach_driver+0x104/0x160 drivers/base/dd.c:958
    [<ffffffff82c3978d>] bus_for_each_drv+0xcd/0x120 drivers/base/bus.c:457
    [<ffffffff82c3cf2a>] __device_attach+0xfa/0x290 drivers/base/dd.c:1030
    [<ffffffff82c3aefa>] bus_probe_device+0xca/0xd0 drivers/base/bus.c:532
    [<ffffffff82c373ae>] device_add+0x9be/0xc90 drivers/base/core.c:3625
    [<ffffffff832ce6b7>] usb_set_configuration+0x967/0xc70 drivers/usb/core/message.c:2207
    [<ffffffff832e138c>] usb_generic_driver_probe+0x9c/0xf0 drivers/usb/core/generic.c:238



Tested on:

commit:         d3fa86b1 Merge tag 'net-6.7-rc3' of git://git.kernel.o..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=142ccff0e80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=f1b9d95ada516af
dashboard link: https://syzkaller.appspot.com/bug?extid=83763e624cfec6b462cb
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=10f560a4e80000