Re: [PATCH v2 0/5] btrfs: zoned: remove extent_buffer redirtying

From: David Sterba
Date: Thu Nov 23 2023 - 14:02:26 EST


On Thu, Nov 23, 2023 at 07:47:14AM -0800, Johannes Thumshirn wrote:
> Since the beginning of zoned mode, I've promised Josef to get rid of the
> extent_buffer redirtying, but never actually got around to doing so.
>
> Then 2 weeks ago our CI has hit an ASSERT() in this area and I started to look
> into it again. After some discussion with Christoph we came to the conclusion
> to finally take the time and get rid of the extent_buffer redirtying once and
> for all.
>
> Patch one renames EXTENT_BUFFER_NO_CHECK into EXTENT_BUFFER_ZONED_ZEROOUT,
> because this fits the new model somewhat better.
>
> Number two sets the cancel bit instead of clearing the dirty bit from a zoned
> extent_buffer.
>
> Number three removes the last remaining bits of btrfs_redirty_list_add().
>
> The last two patches in this series are just trivial cleanups I came across
> while looking at the code.
>
> ---
> Changes in v2:
> - Rename EXTENT_BUFFER_CANCELLED to EXTENT_BUFFER_ZONED_ZEROOUT
> - Add comments why we're marking the buffer as zeroout and zero it.
> - Add Reviews from Josef and Christoph
> - Link to v1: https://lore.kernel.org/r/20231121-josef-generic-163-v1-0-049e37185841@xxxxxxx
>
> ---
> Johannes Thumshirn (5):
> btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_ZONED_ZEROOUT
> btrfs: zoned: don't clear dirty flag of extent buffer
> btrfs: remove now unneeded btrfs_redirty_list_add
> btrfs: use memset_page instead of opencoding it
> btrfs: reflow btrfs_free_tree_block

With the rename in patch 5/5 added to misc-next, thanks.