Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

From: Sui Jingfeng
Date: Thu Nov 23 2023 - 11:30:03 EST


Hi,

On 2023/11/24 00:06, Dmitry Baryshkov wrote:
On Thu, 23 Nov 2023 at 17:41, Sui Jingfeng <sui.jingfeng@xxxxxxxxx> wrote:
Hi,


On 2023/11/23 16:08, Dmitry Baryshkov wrote:
The semantics of DRM_BRIDGE_ATTACH_NO_CONNECTOR flag are implement-defined,
No, they are not. Semantics are pretty simple: do not create the
drm_connector instance. Pass the flag to the next bridge in the chain.

Then, my problem is that do we allow create a drm_connector instance in drm bridge
driver nowadays?
Yes, if there is no DRM_BRIDGE_ATTACH_NO_CONNECTOR. But that's deprecated IMO.

Then can you read the code in bridge/ti-tfp410.c please?
The tfp410_attach() function will create drm_connector instance manually
if the conditional (flags == 0) is true.