Re: [PATCH] perf cs-etm: Bump minimum OpenCSD version to ensure a bugfix is present

From: Arnaldo Carvalho de Melo
Date: Thu Nov 23 2023 - 09:31:34 EST


Em Sun, Sep 03, 2023 at 08:36:35PM -0700, Ian Rogers escreveu:
> On Fri, Sep 1, 2023 at 6:37 AM James Clark <james.clark@xxxxxxx> wrote:
> >
> > Since commit d927ef5004ef ("perf cs-etm: Add exception level consistency
> > check"), the exception that was added to Perf will be triggered unless
> > the following bugfix from OpenCSD is present:
> >
> > - _Version 1.2.1_:
> > - __Bugfix__:
> > ETM4x / ETE - output of context elements to client can in some
> > circumstances be delayed until after subsequent atoms have been
> > processed leading to incorrect memory decode access via the client
> > callbacks. Fixed to flush context elements immediately they are
> > committed.
> >
> > Rather than remove the assert and silently fail, just increase the
> > minimum version requirement to avoid hard to debug issues and
> > regressions.
> >
> > Signed-off-by: James Clark <james.clark@xxxxxxx>
>
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks, applied to perf-tools-next.

- Arnaldo