Re: [PATCH V5 13/20] platform/x86/intel/pmc: Cleanup SSRAM discovery

From: Ilpo Järvinen
Date: Thu Nov 23 2023 - 09:26:29 EST


On Wed, 22 Nov 2023, David E. Box wrote:

> Clean up the code handling SSRAM discovery. Handle all resource allocation
> and cleanup in pmc_core_ssram_get_pmc(). Return the error status from this
> function but only fail the init if we fail to discover the primary PMC.
>
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>

Very easy to follow, thanks for making it this way (in fact so easy
I started to doubt my eyes as I didn't find any flaws in it :-)).

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.