Re: [PATCH] riscv: declare overflow_stack as exported from traps.c

[Ben Dooks]

On 23/11/2023 13:51, Conor Dooley wrote:
> On Thu, Nov 23, 2023 at 01:42:14PM +0000, Ben Dooks wrote:
> > The percpu area overflow_stacks is exported from arch/riscv/kernel/traps.c
> > for use in the entry code, but is not declared anywhere. Add the relevant
> > declaration to arch/riscv/include/asm/stacktrace.h to silence the following
> > sparse warning:
> >
> > arch/riscv/kernel/traps.c:395:1: warning: symbol '__pcpu_scope_overflow_stack' was not declared. Should it be static?
> >
> > We don't add the stackinfo_get_overflow() call as for some of the other
> > architectures as this doesn't seem to be used yet, so just silence the
> > warning.
> >
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> I suppose this should also be
> Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")

Thanks, never sure if the Fixes: should be applied when it is simply a
warning fix and there's nothing actually being currently flagging an
issue with anything else using it (currently just the assembly)

--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html